Seems low risk, potentially high reward. I can run some tests next week to get a rough idea of how compression ratios differ as well as if there's a difference in performance.
I won't be testing correctness, just looking at the performance profile. Jon On Fri, Feb 15, 2019 at 9:56 AM Michael Shuler <mich...@pbandjelly.org> wrote: > +0.5 > > I skimmed the jira and github diff and a few things came to mind: > - There are multiple comments about using an older jar than the latest > version. > - I did not see any performance test results to form an opinion on any > gains/caveats as a user. This was the first thing I looked for. > - I did not see any conf/cassandra.yaml comment in the diff for the > valid class_name configuration option to use. > > Seems interesting, and there are comments about 4.0 being in a freeze > and all, but OK on it being non-default. > > -- > Michael > > On 2/15/19 11:43 AM, Ariel Weisberg wrote: > > Hi, > > > > I am +1 since it's an additional compressor and not the default. > > > > Ariel > > > > On Fri, Feb 15, 2019, at 11:41 AM, Dinesh Joshi wrote: > >> Hey folks, > >> > >> Just wanted to get a pulse on whether we can proceed with ZStd support. > >> The consensus on the ticket was that it’s a very valuable addition > >> without any risk of destabilizing 4.0. It’s ready to go if there aren’t > >> any objections. > >> > >> Dinesh > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >> For additional commands, e-mail: dev-h...@cassandra.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > For additional commands, e-mail: dev-h...@cassandra.apache.org > > -- Jon Haddad http://www.rustyrazorblade.com twitter: rustyrazorblade
