I'll do - - -- --- ----- -------- ------------- Jacek Lewandowski
czw., 30 mar 2023 o 22:09 Miklosovic, Stefan <stefan.mikloso...@netapp.com> napisał(a): > Hi list, > > we are looking for one more committer to take a look at this patch (1, 2). > > It looks like there is a lot to go through because of number of files > modified (around 200) but changes are really just about moving everything > to CassandraRelevantProperties. I do not think that it should take more > than 1 hour of dedicated effort and we are done! > > Thanks in advance to whoever reviews this. > > I want to especially thank Maxim for his perseverance in this matter and I > hope we will eventually deliver this work to trunk. > > (1) https://github.com/apache/cassandra/pull/2046 > (2) https://issues.apache.org/jira/browse/CASSANDRA-17797 > > Regards > > Regards > > ________________________________________ > From: Miklosovic, Stefan <stefan.mikloso...@netapp.com> > Sent: Wednesday, March 22, 2023 14:34 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Moving system property names to the > CassandraRelevantProperties > > NetApp Security WARNING: This is an external email. Do not click links or > open attachments unless you recognize the sender and know the content is > safe. > > > > > Hi Maxim, > > thanks for letting us know. > > I reviewed it couple months ago but I can revisit it to double check. We > need the second reviewer. Until we find somebody, we can not merge this. > > If anybody wants to take a look, it would be awesome. It seems like a lot > of changes / files touched but it is just about centralizing all properties > scattered around the code base into one place. > > Regards > > ________________________________________ > From: Maxim Muzafarov <mmu...@apache.org> > Sent: Tuesday, March 21, 2023 22:59 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Moving system property names to the > CassandraRelevantProperties > > NetApp Security WARNING: This is an external email. Do not click links or > open attachments unless you recognize the sender and know the content is > safe. > > > > > Hello everyone, > > This a friendly reminder that some help is still needed with the review :-) > I have resolved all the conflicts that have arisen in the last month or > two. > > If you'd like to invest some time in code clarity, please take a look: > https://github.com/apache/cassandra/pull/2046/files > > On Wed, 8 Feb 2023 at 19:48, Maxim Muzafarov <mmu...@apache.org> wrote: > > > > Hello everyone, > > > > > > We are trying to clean up the source code around the direct use of > > system properties and make this use more manageable and transparent. > > To achieve this, I have prepared a patch that moves all system > > property names to the CassandraRelevantProperties, which in turn makes > > some of the properties visible to a user through the > > SystemPropertiesTable virtual table. > > > > The patch has passed a few rounds of review, but we still need another > > pair of eyes to make sure we are not missing anything valuable. > > Please, take a look at the patch. > > > > You can find all the changes here: > > https://issues.apache.org/jira/browse/CASSANDRA-17797 > > > > > > I'd also like to share the names of the properties that will appear in > > the SystemPropertiesTable, the appearance of which is related to the > > public API changes we agreed to discuss on the dev list. > > > > > > The public API changes > > > > Newly production system properties added: > > > > io.netty.eventLoopThreads > > io.netty.transport.estimateSizeOnSubmit > > java.security.auth.login.config > > javax.rmi.ssl.client.enabledCipherSuites > > javax.rmi.ssl.client.enabledProtocols > > ssl.enable > > log4j2.disable.jmx > > log4j2.shutdownHookEnabled > > logback.configurationFile > > > > Newly added and used for tests only: > > > > invalid-legacy-sstable-root > > legacy-sstable-root > > org.apache.cassandra.tools.UtilALLOW_TOOL_REINIT_FOR_TEST > > org.caffinitas.ohc.segmentCount > > suitename > > sun.stderr.encoding > > sun.stdout.encoding > > test.bbfailhelper.enabled > > write_survey >
