+1 from me too. I would support removing all of the optional checks from jar/test as I also hit issues with rat from time to time while iterating, as long as the CI system runs them and makes it very clear for any committer there are failures.
On Mon, Jul 10, 2023 at 9:40 AM Josh McKenzie <jmcken...@apache.org> wrote: > > - Remove the checkstyle dependency from "jar" and "test" > - Create a single "check" target that includes all the checks we > expect to pass in the CI (currently Checkstyle, RAT, and Eclipse-Warnings), > making this task the default. > > +1 here. > > (of note: haven't forgotten the request from this thread to share local > env; just gotten sidetracked by things and also realized how little I've > actually modified locally since I just run most of the linting against > delta'ed files only to keep my changed work in compliance. Still a very > noisy mess when SpotBugs is run against the entire codebase proper) > > On Mon, Jul 10, 2023, at 7:13 AM, Brandon Williams wrote: > > On Mon, Jul 10, 2023 at 6:07 AM Jacek Lewandowski > <lewandowski.ja...@gmail.com> wrote: > > Remove the checkstyle dependency from "jar" and "test" > > Create a single "check" target that includes all the checks we expect to > pass in the CI (currently Checkstyle, RAT, and Eclipse-Warnings), making > this task the default. > > I support this. Having checkstyle run when building is clearly > constant friction for many, even though you can disable it. > > >
