Henk, I'd appreciate any patch that increases the code quality of Castor. In my view, a patch per 'smell' would be easier to handle. Bare in mind that it does not pay off to fix smelles within the gererated classes (from e.g. The mapping.xsd file), as they can be (re)generated at any time.
And yes, individual issues would be appreciated, possible maybe created as sub-tasks off an initial issue that described the context. Just dreaming .. ;-). Werner > -----Original Message----- > From: Henk van Voorthuijsen [mailto:[EMAIL PROTECTED] > Sent: Donnerstag, 06. April 2006 17:25 > To: dev@castor.codehaus.org > Subject: Re: [castor-dev] Possible problem in Castor XML > > Werner, since I'm not the OP, I think I will wait for Dave to > create the issue... :) > > On a similar not though, I got curious and took a long hard > look at the code with almost all warning flags on. > Eclipse reported about 1800 warnings, most of which are a > no-brainer to fix. > I'm currently thinking of submitting a series of patches, and > I want to know what is easier to handle: > Fix the more obvious warnings one package at a time, or > submit one patch per warning type? > I also wonder whether this should go into its own issue... > > Henk > > On 06/04/2006, at 15:17, Werner Guttmann wrote: > > > Can you please add this findings to the issue you created. > > > > Werner > > > >> -----Original Message----- > >> From: Henk van Voorthuijsen [mailto:[EMAIL PROTECTED] > >> Sent: Donnerstag, 06. April 2006 13:59 > >> To: dev@castor.codehaus.org > >> Subject: Re: [castor-dev] Possible problem in Castor XML > >> > >> > >> On 05/04/2006, at 21:16, [EMAIL PROTECTED] wrote: > >> > >> Eclipse also reports this for > >> - org.exolab.castor.dsml.Consumer.java:125 > >> - org.exolab.castor.xml.util:XMLClassDescriptorImpl.java:1240 > >> - org.exolab.castor.xml.util:XMLClassDescriptorImpl.java:1249 > >> > > ------------------------------------------------- > If you wish to unsubscribe from this list, please send an > empty message to the following address: > > [EMAIL PROTECTED] > ------------------------------------------------- > > > ------------------------------------------------- If you wish to unsubscribe from this list, please send an empty message to the following address: [EMAIL PROTECTED] -------------------------------------------------
