andi-huber commented on code in PR #3080:
URL: https://github.com/apache/causeway/pull/3080#discussion_r2307514442
##########
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/object/domainobjectlayout/IconFacetViaDomainObjectLayoutAnnotationUsingIconUiEvent.java:
##########
@@ -21,89 +21,97 @@
import java.util.Optional;
import java.util.function.BiConsumer;
+import org.springframework.util.ClassUtils;
+
import org.apache.causeway.applib.annotation.DomainObjectLayout;
+import org.apache.causeway.applib.annotation.ObjectSupport;
import org.apache.causeway.applib.events.EventObjectBase;
import org.apache.causeway.applib.events.ui.IconUiEvent;
import org.apache.causeway.commons.internal.base._Casts;
import org.apache.causeway.commons.internal.base._Strings;
+import org.apache.causeway.core.metamodel.facetapi.Facet;
import org.apache.causeway.core.metamodel.facetapi.FacetHolder;
import org.apache.causeway.core.metamodel.facets.object.icon.IconFacet;
-import org.apache.causeway.core.metamodel.facets.object.icon.IconFacetAbstract;
import org.apache.causeway.core.metamodel.object.ManagedObject;
import org.apache.causeway.core.metamodel.object.ManagedObjects;
import org.apache.causeway.core.metamodel.object.MmEventUtils;
import
org.apache.causeway.core.metamodel.services.events.MetamodelEventService;
-public class IconFacetViaDomainObjectLayoutAnnotationUsingIconUiEvent
-extends IconFacetAbstract {
+public record IconFacetViaDomainObjectLayoutAnnotationUsingIconUiEvent(
Review Comment:
I'm confused by this facet name.
Besides, UI Event for Icons needs an overhaul, only supports the `iconName`
but should support the newer variants as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@causeway.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
