andi-huber commented on code in PR #3080:
URL: https://github.com/apache/causeway/pull/3080#discussion_r2307517978
##########
api/applib/src/main/java/org/apache/causeway/applib/services/title/TitleService.java:
##########
@@ -18,24 +18,27 @@
*/
package org.apache.causeway.applib.services.title;
+import org.apache.causeway.applib.annotation.ObjectSupport.IconResource;
+import org.apache.causeway.applib.annotation.ObjectSupport.IconWhere;
+
/**
* Provides methods to programmatically obtain the title and icon of a domain
* object.
*
- * @since 1.x {@index}
+ * @since 1.x {@index} revised for 4.0
*/
public interface TitleService {
/**
* Returns the title of the object (as rendered in the UI by the
* framework's viewers).
*/
- String titleOf(final Object domainObject);
+ String titleOf(Object domainObject);
/**
- * Returns the icon name of the object (as rendered in the UI by the
+ * Returns the icon of the object (as rendered in the UI by the
* framework's viewers).
*/
- String iconNameOf(final Object domainObject);
+ IconResource iconOf(Object domainObject, IconWhere iconWhere);
Review Comment:
need mignotes mention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@causeway.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
