On 12/02/2016 9:55pm, Dzmitry Kazimirchyk wrote:
> On 2/12/16 12:46 PM, Aristedes Maniatis wrote:
>> On 21/01/2016 11:39pm, Dzmitry Kazimirchyk wrote:
>>>> >>HttpROPConnector might do with some way to set the cookie name. You made 
>>>> >>SESSION_COOKIE_NAME final for some reason.
>>> >
>>> >SESSION_COOKIE_NAME is just the name of the HTTP session header, but 
>>> >having some sort of pipeline requests go through to be able to add various 
>>> >parameters like compression, custom cookies, etc. might be beneficial.
>> A pipeline could be nice, but maybe more work than is needed. A user could 
>> just subclass HttpROPConnector to most of what they want. If 
>> SESSION_COOKIE_NAME wasn't final...
> 
> Sorry, not really following... SESSION_COOKIE_NAME is just a string constant 
> for the default name of the session cookie. Users can still add any cookies 
> with any names they want by overriding "addSessionCookie" or "doRequest" 
> method of HttpROPConnector.

Ah, I see. I thought it was used elsewhere as the authoritative name of the 
cookie rather than just the default. Then that's all good.

Ari



-- 
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A

Reply via email to