waitinfuture commented on code in PR #990:
URL:
https://github.com/apache/incubator-celeborn/pull/990#discussion_r1033742882
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -692,6 +834,13 @@ class LifecycleManager(appId: String, val conf:
CelebornConf) extends RpcEndpoin
// check if there exists request for the partition, if do just register
val requests = changePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
inBatchPartitions.computeIfAbsent(shuffleId, inBatchShuffleIdRegisterFunc)
+
+ // handle hard split
+ if (batchHandleCommitPartitionEnabled && cause.isDefined && cause.get ==
StatusCode.HARD_SPLIT) {
+ committedPartitionInfo.get(shuffleId).commitPartitionRequests
Review Comment:
And we can convert ConcurrentHashMap/KeySetView to HashMap/HashSet then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
