RexXiong commented on code in PR #990:
URL:
https://github.com/apache/incubator-celeborn/pull/990#discussion_r1034248354
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -249,6 +284,100 @@ class LifecycleManager(appId: String, val conf:
CelebornConf) extends RpcEndpoin
batchHandleChangePartitionRequestInterval,
TimeUnit.MILLISECONDS)
}
+
+ batchHandleCommitPartitionSchedulerThread.foreach {
+ _.scheduleAtFixedRate(
+ new Runnable {
+ override def run(): Unit = {
+ committedPartitionInfo.asScala.foreach { case (shuffleId,
shuffleCommittedInfo) =>
+ batchHandleCommitPartitionExecutors.submit {
+ new Runnable {
+ override def run(): Unit = {
+ if (inProcessStageEndShuffleSet.contains(shuffleId) ||
Review Comment:
suggest move the if code block into shuffleCommittedInfo synchronized block
in the else branch，because It may be overlap as stageEnd commit and this commit
happen at the same time，commitPartitionRequests may contains partitions which
are already committed by stageEnd process。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
