+1 (non-binding) I checked the following things: - git commit hash is correct. - download links are valid. - release files are in correct location. - release files have the word incubating in their name. - signatures and checksums are good. - DISCLAIMER, LICENSE and NOTICE files exist. - build success from source code(ubuntu 16.04). ``` ./build/make-distribution.sh --release ./build/make-distribution.sh -Pspark-3.3 ```
Thanks, Yihe Li On 2023/12/22 05:37:52 Cheng Pan wrote: > +1 > > - all links are valid > - checksums and signatures are good > - artifacts name contain “incubating” > - build success on Ubuntu 22.04 JDK 17 x86 with the command: > `build/make-distribution.sh -Pspark-3.3` > > Cheng Pan > > > On Dec 22, 2023, at 12:16, Shaoyun Chen <[email protected]> wrote: > > > > +1 (non-binding) > > > > I checked the following things: > > > > - signatures are good. > > ``` > > gpg --import KEYS > > gpg --verify apache-celeborn-0.3.2-incubating-source.tgz.asc > > gpg --verify apache-celeborn-0.3.2-incubating-bin.tgz.asc > > ``` > > - checksums are good. > > ``` > > sha512sum --check apache-celeborn-0.3.2-incubating-source.tgz.sha512 > > sha512sum --check apache-celeborn-0.3.2-incubating-bin.tgz.sha512 > > ``` > > - build success from source code. > > ``` > > ./build/make-distribution.sh -Pspark-3.2 > > ./build/make-distribution.sh --release > > ``` > > > > rexxiong <[email protected]> 于2023年12月22日周五 11:09写道： > >> > >> +1 (binding) > >> I checked > >> - Download links are valid. > >> - git commit hash is correct > >> - Checksums and signatures are valid. > >> - No binary files in the source release > >> - Files have the word incubating in their name. > >> - DISCLAIMER,LICENSE and NOTICE files exist. > >> > >> Thanks, > >> Jiashu Xiong > >> > >> Fu Chen <[email protected]> 于2023年12月21日周四 21:57写道： > >> > >>> +1 > >>> > >>> I checked > >>> - download links are valid. > >>> - git commit hash is correct. > >>> - no binary files in the source release. > >>> - signatures are good. > >>> ``` > >>> gpg --import KEYS > >>> gpg --verify apache-celeborn-0.3.2-incubating-source.tgz.asc > >>> gpg --verify apache-celeborn-0.3.2-incubating-bin.tgz.asc > >>> ``` > >>> - checksums are good. > >>> ``` > >>> sha512sum --check apache-celeborn-0.3.2-incubating-source.tgz.sha512 > >>> sha512sum --check apache-celeborn-0.3.2-incubating-bin.tgz.sha512 > >>> ``` > >>> - build success from source code (Pop!_OS 22.04 LTS). > >>> ``` > >>> ./build/mvn clean package -DskipTests -Pspark-3.4 > >>> ``` > >>> > >>> Keyong Zhou <[email protected]> 于2023年12月21日周四 16:55写道： > >>> > >>>> +1 (binding) > >>>> > >>>> I checked > >>>> - git commit hash is correct. > >>>> - links are valid. > >>>> - "incubating" is in the name. > >>>> - PGP keys are good. > >>>> - hashes are correct. > >>>> - LICENSE looks good. > >>>> - NOTICE looks good. > >>>> - DISCLAIMER exists. > >>>> - build success from source code (macOS). ``` > >>> ./build/make-distribution.sh > >>>> --release ``` > >>>> > >>>> Thanks, > >>>> Keyong Zhou > >>>> > >>>> Nicholas Jiang <[email protected]> 于2023年12月21日周四 14:06写道： > >>>> > >>>>> Hi Celeborn community, > >>>>> > >>>>> > >>>>> This is a call for a vote to release Apache Celeborn (Incubating) > >>>>> 0.3.2-incubating-rc1 > >>>>> > >>>>> > >>>>> The git tag to be voted upon: > >>>>> > >>>>> > >>>> > >>> https://github.com/apache/incubator-celeborn/releases/tag/v0.3.2-incubating-rc1 > >>>>> > >>>>> > >>>>> The git commit hash: > >>>>> bce190d8a0a53434ef57ef33e53720f5bf4d14d6 source and binary artifacts > >>> can > >>>> be > >>>>> found at: > >>>>> > >>>>> > >>>> > >>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.3.2-incubating-rc1 > >>>>> > >>>>> > >>>>> The staging repo: > >>>>> > >>>> > >>> https://repository.apache.org/content/repositories/orgapacheceleborn-1045 > >>>>> > >>>>> > >>>>> Fingerprint of the PGP key release artifacts are signed with: > >>>>> D73CADC1DAB63BD3C770BB6D9476842D24B7C885 > >>>>> > >>>>> > >>>>> My public key to verify signatures can be found in: > >>>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > >>>>> > >>>>> > >>>>> The vote will be open for at least 72 hours or until the necessary > >>>>> number of votes are reached. > >>>>> > >>>>> > >>>>> Please vote accordingly: > >>>>> > >>>>> > >>>>> [ ] +1 approve > >>>>> [ ] +0 no opinion > >>>>> [ ] -1 disapprove (and the reason) > >>>>> > >>>>> > >>>>> Checklist for release: > >>>>> > >>>>> > >>>> > >>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > >>>>> Steps to validate the release: > >>>>> https://www.apache.org/info/verification.html > >>>>> > >>>>> > >>>>> * Download links, checksums and PGP signatures are valid. > >>>>> * Source code distributions have correct names matching the current > >>>>> release. > >>>>> * Release files have the word incubating in their name. > >>>>> * DISCLAIMER, LICENSE and NOTICE files are correct. > >>>>> * All files have license headers if necessary. > >>>>> * No unlicensed compiled archives bundled in source archive. > >>>>> * The source tarball matches the git tag. > >>>>> * Build from source is successful. > >>>>> > >>>>> > >>>>> Regards, > >>>>> Nicholas Jiang > >>>> > >>> > >
