abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation URL: https://github.com/apache/celix/pull/172#discussion_r401548808
########## File path: bundles/pubsub/pubsub_spi/include/pubsub_utils.h ########## @@ -165,10 +165,11 @@ bool pubsub_utils_matchEndpoint( * * @param bundle The bundle where the properties reside. * @param topic The topic name. + * @param scope The scope name. * @param isPublisher true if the topic properties for a publisher should be found. * @return The topic properties if found or NULL. */ -celix_properties_t* pubsub_utils_getTopicProperties(const celix_bundle_t *bundle, const char *topic, bool isPublisher); +celix_properties_t* pubsub_utils_getTopicProperties(const celix_bundle_t *bundle, const char *topic, const char *scope, bool isPublisher); Review comment: Just a suggestion, placing scope before topic makes more sense imo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
