abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and
add interfacing for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401551326
##########
File path: bundles/pubsub/pubsub_spi/src/pubsub_utils_match.c
##########
@@ -227,6 +228,7 @@ double pubsub_utils_matchSubscriber(
pubsub_get_topic_properties_data_t data;
data.isPublisher = false;
data.topic = celix_properties_get(svcProperties, PUBSUB_SUBSCRIBER_TOPIC,
NULL);
+ data.scope = celix_properties_get(svcProperties, PUBSUB_SUBSCRIBER_SCOPE,
PUBSUB_SUBSCRIBER_SCOPE_DEFAULT);
Review comment:
Just a heads up, with PR 181, the default scope is actually NULL, not
"default". Only in places where a value is needed, a value is used (discovery
and internal map key).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
