Oipo commented on a change in pull request #293:
URL: https://github.com/apache/celix/pull/293#discussion_r525924963
##########
File path: libs/framework/include/celix/dm/Component_Impl.h
##########
@@ -63,7 +88,7 @@ Component<T>& Component<T>::addInterfaceWithName(const
std::string &serviceName,
template<class T>
template<class I>
-Component<T>& Component<T>::addInterface(const std::string &version, const
Properties &properties) {
+inline Component<T>& Component<T>::addInterface(const std::string &version,
const Properties &properties) {
Review comment:
Rather than experience, let's look at the assembly generated:
https://godbolt.org/z/cYasbb
No difference. Inline does not do what you think, it is only useful when
getting linkage issues, which is not the case here.
Long explanation available on stackoverflow:
https://stackoverflow.com/a/1759575/1460998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
