pnoltes commented on a change in pull request #293:
URL: https://github.com/apache/celix/pull/293#discussion_r526416460
##########
File path: libs/framework/include/celix/dm/Component_Impl.h
##########
@@ -63,7 +88,7 @@ Component<T>& Component<T>::addInterfaceWithName(const
std::string &serviceName,
template<class T>
template<class I>
-Component<T>& Component<T>::addInterface(const std::string &version, const
Properties &properties) {
+inline Component<T>& Component<T>::addInterface(const std::string &version,
const Properties &properties) {
Review comment:
Thanks.
I removed the inline only for the template functions and that indeed works.
I was under the impressions that the inline was also explicitly needed for
template functions.
For now, I want to keep the non template function inline. This will keep the
celix/dm functionality header only, part of the celix_framework, but without
linking the celix_framework to C++ (libstd++).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
