rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r744272425
##########
File path: bundles/pubsub/pubsub_admin_tcp/CMakeLists.txt
##########
@@ -32,15 +30,37 @@ add_celix_bundle(celix_pubsub_admin_tcp
src/pubsub_tcp_common.c
)
-set_target_properties(celix_pubsub_admin_tcp PROPERTIES INSTALL_RPATH
"$ORIGIN")
target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::pubsub_spi
Celix::pubsub_utils)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework
Celix::dfi Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework
Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
target_include_directories(celix_pubsub_admin_tcp PRIVATE src)
# cmake find package UUID set the wrong include dir for OSX
if (NOT APPLE)
target_link_libraries(celix_pubsub_admin_tcp PRIVATE UUID::lib)
endif()
install_celix_bundle(celix_pubsub_admin_tcp EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
add_library(Celix::celix_pubsub_admin_tcp ALIAS celix_pubsub_admin_tcp)
+
+
+#Tmp psa tcp _v2 target
+add_celix_bundle(celix_pubsub_admin_tcp_v2
+ BUNDLE_SYMBOLICNAME "apache_celix_pubsub_admin_tcp_v2"
+ VERSION "2.0.0"
+ GROUP "Celix/PubSub"
+ SOURCES
+ src/psa_activator.c
+ src/pubsub_tcp_admin.c
+ src/pubsub_tcp_topic_sender.c
+ src/pubsub_tcp_topic_receiver.c
+ src/pubsub_tcp_handler.c
+ src/pubsub_tcp_common.c
+)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::pubsub_spi
Celix::pubsub_utils)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::framework
Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::shell_api)
+target_include_directories(celix_pubsub_admin_tcp_v2 PRIVATE src)
+if (NOT APPLE)
+ target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE UUID::lib)
+endif()
+install_celix_bundle(celix_pubsub_admin_tcp_v2 EXPORT celix COMPONENT pubsub)
Review comment:
This can be removed, right (it probably is the same as the
`celix_pubsub_admin_tcp` target) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
