rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r744272616



##########
File path: bundles/pubsub/pubsub_admin_zmq/CMakeLists.txt
##########
@@ -45,17 +42,32 @@ add_celix_bundle(celix_pubsub_admin_zmq
         ${ZMQ_CRYPTO_C}
 )
 
-set_target_properties(celix_pubsub_admin_zmq PROPERTIES INSTALL_RPATH 
"$ORIGIN")
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE
-
         Celix::framework Celix::dfi Celix::log_helper Celix::utils
-        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB}
-)
+        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB})
+target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::pubsub_spi 
Celix::pubsub_utils )
-target_include_directories(celix_pubsub_admin_zmq PRIVATE
-    src
-)
-
+target_include_directories(celix_pubsub_admin_zmq PRIVATE src)
 install_celix_bundle(celix_pubsub_admin_zmq EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 add_library(Celix::celix_pubsub_admin_zmq ALIAS celix_pubsub_admin_zmq)
+
+
+#Tmp psa zmq _v2 target

Review comment:
       `Tmp`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to