PengZheng commented on a change in pull request #401:
URL: https://github.com/apache/celix/pull/401#discussion_r835882710
##########
File path: cmake/celix_project/CelixProject.cmake
##########
@@ -26,8 +26,8 @@ mark_as_advanced(CLEAR ENABLE_THREAD_SANITIZER)
if (ENABLE_ADDRESS_SANITIZER)
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR
"${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
- set(CMAKE_C_FLAGS "-fsanitize=address -fno-omit-frame-pointer
${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "-fsanitize=address -fno-omit-frame-pointer
${CMAKE_CXX_FLAGS}")
+ set(CMAKE_C_FLAGS "-DCPPUTEST_MEM_LEAK_DETECTION_DISABLED
-fsanitize=address -fno-omit-frame-pointer ${CMAKE_C_FLAGS}")
+ set(CMAKE_CXX_FLAGS "-DCPPUTEST_MEM_LEAK_DETECTION_DISABLED
-fsanitize=address -fno-omit-frame-pointer ${CMAKE_CXX_FLAGS}")
Review comment:
When enabling ASAN, it makes no sense to use the inferior CPPUTest
memory leak detection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
