PengZheng commented on a change in pull request #401:
URL: https://github.com/apache/celix/pull/401#discussion_r836076269
##########
File path: cmake/celix_project/CodeCoverage.cmake
##########
@@ -135,7 +135,7 @@ function (setup_target_for_coverage)
# Capturing lcov counters and generating report
COMMAND ${CMAKE_COMMAND} -E make_directory
${CMAKE_BINARY_DIR}/coverage
COMMAND ${LCOV_PATH} --directory ${COVERAGE_SCAN_DIR} --capture
--output-file ${OUTPUT_FILE}
- COMMAND ${LCOV_PATH} --remove ${OUTPUT_FILE} '**/mock/*'
'**/test/*' '**/gtest/*' '**/tst/*' '**/celix/gen/*' '**/googletest_project/*'
'**/glog/*' '/usr/*' --output-file ${OUTPUT_FILE}.cleaned
+ COMMAND ${LCOV_PATH} --remove ${OUTPUT_FILE} '**/mock/*'
'**/.conan/*' '**/test/*' '**/gtest/*' '**/tst/*' '**/celix/gen/*'
'**/googletest_project/*' '**/glog/*' '/usr/*' --output-file
${OUTPUT_FILE}.cleaned
Review comment:
To remove all external dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
