PengZheng commented on code in PR #414:
URL: https://github.com/apache/celix/pull/414#discussion_r848212101
##########
bundles/remote_services/topology_manager/src/topology_manager.c:
##########
@@ -477,33 +479,32 @@ celix_status_t topologyManager_addImportedService(void
*handle, endpoint_descrip
celix_logHelper_log(manager->loghelper, CELIX_LOG_LEVEL_INFO,
"TOPOLOGY_MANAGER: Add imported service (%s; %s).", endpoint->service,
endpoint->id);
+ celixThreadMutex_lock(&manager->rsaListLock);
Review Comment:
Considering services frequently go up and down, it does not seem a good idea
to unconditionally lock rtsListLock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
