PengZheng commented on code in PR #414:
URL: https://github.com/apache/celix/pull/414#discussion_r849022810
##########
bundles/remote_services/topology_manager/src/topology_manager.c:
##########
@@ -288,6 +289,8 @@ celix_status_t topologyManager_rsaRemoved(void * handle,
service_reference_pt re
remote_service_admin_service_t *rsa = (remote_service_admin_service_t
*) service;
celixThreadMutex_lock(&manager->rsaListLock);
+ arrayList_removeElement(manager->rsaList, rsa);
+ celixThreadMutex_unlock(&manager->rsaListLock);
Review Comment:
`topologyManager_rsaRemoved` should be dual to `topologyManager_rsaAdded`:
things should be done in strictly reverse order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
