pnoltes opened a new pull request, #446: URL: https://github.com/apache/celix/pull/446
This PR deprecates all the not celix_ utils functions and moves them in a separate include_deprecated directly. This is done to prepare a celix v3 release where we "just" not install the include_deprecated directories. For this PR default the include_deprecated is still installed, but bundles, libraries and executables in the Celix project still using the deprecated utils headers need to configure this with a `celix_deprecated_utils_headers` cmake function. Further: - The deprecated include dir is added using a separate cmake function to ensure it is not transitive (and still works with static libs, etc) and also to make it possible to run a custom target (`celix-deprecated`) to get a quick overview which targets are still using the deprecated headers. It also helps that the usage of `celix_deprecated_utils_headers` can be easily found with a search function. - The `celix_api.h` header is also moved to the include_deprecated directory, because it also includes non celix_ prefixed headers. Updating the celix_api.h would mean a backwards incompatible update, so for now I want to handle it as a deprecated api. A result of this is that a lot of files are updated, but they mostly are the same updates (replace celix_api.h include with some others includes). - The v3 ci build is removed, because the approach has changed and I think it is not relevant anymore (and maybe never was). - The include_deprecated headers now contains __attribute__((deprecated)) statements and as result, usage will generate a warning (or if configured an error). For Celix itself, the default compiler config will not generate the deprecated warnings (-Wno-deprecated-declarations). Lastly note that a celix v3 release does not (directly) mean that non celix_ prefixed headers cannot be used internally anymore, the header are just not installed anymore. This should give us some time to slowly move aways from the deprecated functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
