pnoltes commented on code in PR #446:
URL: https://github.com/apache/celix/pull/446#discussion_r1050899118
##########
libs/utils/src/properties.c:
##########
@@ -467,11 +468,42 @@ int celix_properties_size(const celix_properties_t
*properties) {
}
celix_properties_iterator_t celix_propertiesIterator_construct(const
celix_properties_t *properties) {
- return hashMapIterator_construct((hash_map_t*)properties);
+ celix_properties_iterator_t iter;
+ hash_map_iterator_t mapIter =
hashMapIterator_construct((hash_map_t*)properties);
+ iter._data1 = mapIter.map;
+ iter._data2 = mapIter.next;
+ iter._data3 = mapIter.current;
+ iter._data4 = mapIter.expectedModCount;
+ iter._data5 = mapIter.index;
Review Comment:
To be honest, I prefer the current way.
Maybe there is some overhead, but IMO the mapping is - a bit - more
explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
