[GitHub] [celix] stegemr commented on a diff in pull request #453: Add COPY / NO_COPY option in the celix_container_bundles cmake function

[GitBox]

stegemr commented on code in PR #453:
URL: https://github.com/apache/celix/pull/453#discussion_r1044810889


##########
cmake/cmake_celix/ContainerPackaging.cmake:
##########
@@ -263,7 +264,16 @@ 
$<JOIN:$<TARGET_PROPERTY:${CONTAINER_TARGET},CONTAINER_EMBEDDED_PROPERTIES>,\\n\
 "
         )
 
-        file(GENERATE OUTPUT "${LAUNCHER_SRC}" INPUT "${STAGE1_LAUNCHER_SRC}")
+        #Rerun generate to do a second parsing of generator expressions
+        file(GENERATE OUTPUT "${STAGE2_LAUNCHER_SRC}" INPUT 
"${STAGE1_LAUNCHER_SRC}")

Review Comment:
   Second stage is needed because src needs 2 passes of file generate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org