pnoltes commented on code in PR #453:
URL: https://github.com/apache/celix/pull/453#discussion_r1045273794
##########
cmake/cmake_celix/ContainerPackaging.cmake:
##########
@@ -263,7 +264,16 @@
$<JOIN:$<TARGET_PROPERTY:${CONTAINER_TARGET},CONTAINER_EMBEDDED_PROPERTIES>,\\n\
"
)
- file(GENERATE OUTPUT "${LAUNCHER_SRC}" INPUT "${STAGE1_LAUNCHER_SRC}")
+ #Rerun generate to do a second parsing of generator expressions
+ file(GENERATE OUTPUT "${STAGE2_LAUNCHER_SRC}" INPUT
"${STAGE1_LAUNCHER_SRC}")
Review Comment:
I reverted the add_custom_target for the Celix container main files. This
should not be needed and retesting this the `file(GENERATE ...)` cmake function
does not overwrite the file if the input is not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
