pnoltes commented on code in PR #452:
URL: https://github.com/apache/celix/pull/452#discussion_r1045093786
##########
bundles/cxx_remote_services/integration/src/TestExportImportRemoteServiceFactory.cc:
##########
@@ -263,13 +263,16 @@ class CalculatorImportServiceFactory final : public
celix::rsa::IImportServiceFa
auto& cmp =
ctx->getDependencyManager()->createComponent(std::make_unique<ImportedCalculator>(logHelper));
cmp.createServiceDependency<pubsub_publisher>(PUBSUB_PUBLISHER_SERVICE_NAME)
.setRequired(true)
+ .setStrategy(DependencyUpdateStrategy::locking)
Review Comment:
Yes, you are correct is should not matter.
The suspend or locking strategy should not matter because the export/import
service components should only start when all required dependencies are
available (and all deps are required).
I though the component maybe was starting ans stopping which resulted in
flaky / unstable test result due to timing issue, but this should not be the
case.
The problem for me is that I cannot reproduce this issue on my local machine
(ubuntu or mac os), but I will test if the test are still stable if this is
reverted to suspend instead of locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
