pnoltes commented on code in PR #452:
URL: https://github.com/apache/celix/pull/452#discussion_r1045274364
##########
bundles/cxx_remote_services/integration/src/TestExportImportRemoteServiceFactory.cc:
##########
@@ -263,13 +263,16 @@ class CalculatorImportServiceFactory final : public
celix::rsa::IImportServiceFa
auto& cmp =
ctx->getDependencyManager()->createComponent(std::make_unique<ImportedCalculator>(logHelper));
cmp.createServiceDependency<pubsub_publisher>(PUBSUB_PUBLISHER_SERVICE_NAME)
.setRequired(true)
+ .setStrategy(DependencyUpdateStrategy::locking)
Review Comment:
I added a retry loop outside of the `ctx->useService` IMO this is cleaner
and now the test seems stable.
Note that although I have change/improved some pubsub code, these changes
were not the fix for the issue. The fix for #397 was a better test setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
