PengZheng commented on code in PR #476: URL: https://github.com/apache/celix/pull/476#discussion_r1117917119
########## libs/framework/include/celix_launcher.h: ########## @@ -68,7 +81,7 @@ int celixLauncher_launch(const char *configFile, celix_framework_t **framework); * * @param config FILE* to the config file (config.properties) * @param framework Output parameter for the framework. - * @return CELIX_SUCCESS if successful. + * @return 0 if successful. */ int celixLauncher_launchWithStream(FILE *config, celix_framework_t **framework); Review Comment: I found that its implementation is removed in 985c35f2f6ef6cd48ba63e8d117a928dfda3fe6a (by accident ?). Should it be recovered or removed completely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
