pnoltes commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1117936690
##########
libs/framework/src/celix_launcher.c:
##########
@@ -256,11 +267,47 @@ static void printEmbeddedBundles() {
celix_arrayList_destroy(embeddedBundles);
}
-static void combine_properties(celix_properties_t *original, const
celix_properties_t *append) {
+static int celixLauncher_createBundleCache(celix_properties_t*
embeddedProperties, const char* configFile) {
+ celix_framework_t* fw = NULL;
+ celix_properties_t* config = celixLauncher_createConfig(configFile,
embeddedProperties);
+ celix_status_t status = framework_create(&fw, config);
Review Comment:
correct. nice catch. Added usage of celix_framework_getConfigProperty to
remedy this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
