pnoltes commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1119900841


##########
libs/framework/include/celix_bundle_context.h:
##########
@@ -1311,7 +1311,7 @@ void celix_bundleContext_vlog(
  * @param defaultValue The default value if the property is not found.
  * @return The property value or the default value if the property is not 
found.
  */
-const char* celix_bundleContext_getProperty(celix_bundle_context_t *ctx, const 
char *key, const char *defaultVal);
+const char* celix_bundleContext_getProperty(celix_bundle_context_t *ctx, const 
char* key, const char* defaultVal);

Review Comment:
   There is no written down coding convection and to be honest, the style has 
changed over the years.
   
   I agree that it is good to write this down and maybe create clang-tidy 
config - or something like that - for this, but nor for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to