PengZheng commented on code in PR #529:
URL: https://github.com/apache/celix/pull/529#discussion_r1179259071
##########
libs/framework/src/module.c:
##########
@@ -454,10 +452,7 @@ static celix_status_t
celix_module_loadLibrariesInManifestEntry(celix_module_t*
if ( (status == CELIX_SUCCESS) && (activator != NULL) &&
(strcmp(trimmedLib, activator) == 0) ) {
*activatorHandle = handle;
- } else if ((status != CELIX_SUCCESS) && (handle != NULL)) {
- celix_libloader_close(fwCtx, handle);
Review Comment:
Note this is dead code, i.e. when handle != NULL we must have status ==
CELIX_SUCCESS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
