PengZheng commented on code in PR #529:
URL: https://github.com/apache/celix/pull/529#discussion_r1179262262
##########
libs/framework/src/module.c:
##########
@@ -501,8 +494,6 @@ celix_status_t celix_module_loadLibraries(celix_module_t*
module) {
celixThreadMutex_lock(&module->handlesLock);
module->bundleActivatorHandle = activatorHandle;
celixThreadMutex_unlock(&module->handlesLock);
- } else if (activatorHandle != NULL) {
- celix_libloader_close(fwCtx, activatorHandle);
Review Comment:
This is indeed a double close. Suppose that we have two private libraries
a.so and b.so and that a.so is an activator,
what will happen if a.so is opened successfully while loading b.so fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
