PengZheng commented on code in PR #544: URL: https://github.com/apache/celix/pull/544#discussion_r1195869466
########## .clang-format: ########## @@ -0,0 +1,27 @@ +BasedOnStyle: LLVM +IndentWidth: 4 +AllowShortIfStatementsOnASingleLine: false +AlwaysBreakTemplateDeclarations: Yes +BinPackArguments: false +BinPackParameters: false +BreakBeforeBraces: Attach +ColumnLimit: 120 +ConstructorInitializerIndentWidth: 4 +Cpp11BracedListStyle: true +DerivePointerAlignment: false +IncludeBlocks: Regroup Review Comment: AFAIK, there is a case where manually organizing headers can be useful: for each .h/.c pairs, e.g., celix_bundle_cache.h(.c), always include the header file (`celix_bundle_cache.h`) in the first line of the non-comment part of the source file (`celix_bundle_cache.c`) to make sure the header file is self-contained, which means it can be used alone. Self-contained header file is really nice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
