WopsS commented on code in PR #544: URL: https://github.com/apache/celix/pull/544#discussion_r1205840272
########## .clang-format: ########## @@ -0,0 +1,27 @@ +BasedOnStyle: LLVM +IndentWidth: 4 +AllowShortIfStatementsOnASingleLine: false +AlwaysBreakTemplateDeclarations: Yes +BinPackArguments: false +BinPackParameters: false +BreakBeforeBraces: Attach +ColumnLimit: 120 +ConstructorInitializerIndentWidth: 4 +Cpp11BracedListStyle: true +DerivePointerAlignment: false +IncludeBlocks: Regroup Review Comment: I've consistently encountered problemswith this setting while developing libraries, particularly when using angle brackets (`<>`) to include header files within the library. However, these problems don't seem to occur when using double quotes (`""`). E.g.: ```cpp // lib/detail/header1.cpp #include <lib/detail/header1.hpp> #include <lib/header2.hpp> #include <lib/header3.hpp> #include <memory> #include <spdlog/spdlog.hpp> ``` will get reorganized in: ```cpp // lib/detail/header1.cpp #include <memory> #include <lib/header2.hpp> #include <lib/header3.hpp> #include <lib/detail/header1.hpp> // This header should be at the top of the file in my opinion. #include <spdlog/spdlog.hpp> ``` while, the following: ```cpp // lib/detail/header1.cpp #include "lib/detail/header1.hpp" #include "lib/header2.hpp" #include "lib/header3.hpp" #include <memory> #include <spdlog/spdlog.hpp> ``` will get reorganized in: ```cpp // lib/detail/header1.cpp #include "lib/detail/header1.hpp" #include <memory> #include "lib/header2.hpp" #include "lib/header3.hpp" #include <spdlog/spdlog.hpp> ``` ########## .clang-format: ########## @@ -0,0 +1,27 @@ +BasedOnStyle: LLVM +IndentWidth: 4 +AllowShortIfStatementsOnASingleLine: false +AlwaysBreakTemplateDeclarations: Yes +BinPackArguments: false +BinPackParameters: false +BreakBeforeBraces: Attach +ColumnLimit: 120 +ConstructorInitializerIndentWidth: 4 +Cpp11BracedListStyle: true +DerivePointerAlignment: false +IncludeBlocks: Regroup Review Comment: I've consistently encountered problems with this setting while developing libraries, particularly when using angle brackets (`<>`) to include header files within the library. However, these problems don't seem to occur when using double quotes (`""`). E.g.: ```cpp // lib/detail/header1.cpp #include <lib/detail/header1.hpp> #include <lib/header2.hpp> #include <lib/header3.hpp> #include <memory> #include <spdlog/spdlog.hpp> ``` will get reorganized in: ```cpp // lib/detail/header1.cpp #include <memory> #include <lib/header2.hpp> #include <lib/header3.hpp> #include <lib/detail/header1.hpp> // This header should be at the top of the file in my opinion. #include <spdlog/spdlog.hpp> ``` while, the following: ```cpp // lib/detail/header1.cpp #include "lib/detail/header1.hpp" #include "lib/header2.hpp" #include "lib/header3.hpp" #include <memory> #include <spdlog/spdlog.hpp> ``` will get reorganized in: ```cpp // lib/detail/header1.cpp #include "lib/detail/header1.hpp" #include <memory> #include "lib/header2.hpp" #include "lib/header3.hpp" #include <spdlog/spdlog.hpp> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
