pnoltes commented on code in PR #584:
URL: https://github.com/apache/celix/pull/584#discussion_r1246337267
##########
bundles/remote_services/rsa_common/CMakeLists.txt:
##########
@@ -15,22 +15,31 @@
# specific language governing permissions and limitations
# under the License.
-add_library(rsa_common STATIC
- src/endpoint_description.c
- src/export_registration_impl.c
- src/import_registration_impl.c
- src/remote_interceptors_handler.c)
+set(RSA_COMMON_SRC
+ src/endpoint_description.c
+ src/export_registration_impl.c
+ src/import_registration_impl.c
+ src/remote_interceptors_handler.c
+ )
+
+add_library(rsa_common STATIC ${RSA_COMMON_SRC})
set_target_properties(rsa_common PROPERTIES OUTPUT_NAME "celix_rsa_common")
target_include_directories(rsa_common PRIVATE src)
target_link_libraries(rsa_common PUBLIC Celix::framework Celix::c_rsa_spi
Celix::log_helper)
celix_deprecated_utils_headers(rsa_common)
celix_deprecated_framework_headers(rsa_common)
+celix_target_hide_symbols(rsa_common)
install(TARGETS rsa_common EXPORT celix COMPONENT rsa DESTINATION
${CMAKE_INSTALL_LIBDIR})
#Setup target aliases to match external usage
add_library(Celix::rsa_common ALIAS rsa_common)
if (ENABLE_TESTING)
+ add_library(rsa_common_cut STATIC ${RSA_COMMON_SRC})
Review Comment:
of course, this was missing a _cut library. 👍 , nice addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
