pnoltes commented on code in PR #584:
URL: https://github.com/apache/celix/pull/584#discussion_r1246339572
##########
libs/framework/CMakeLists.txt:
##########
@@ -66,6 +66,7 @@ install(DIRECTORY include/ DESTINATION
${CMAKE_INSTALL_INCLUDEDIR}/celix/framewo
install(DIRECTORY include_deprecated/ DESTINATION
${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
install(DIRECTORY ${CMAKE_BINARY_DIR}/celix/gen/includes/framework/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
+celix_target_hide_symbols(framework)
Review Comment:
I think celix_target_hide_symbols is more explicit, but this was already
done with the target properties (only for C visiblity, but most libs are only
C).
See
https://github.com/apache/celix/pull/584/files#diff-556b07494eb3b34b34072320fa4a8e72403f81725c9d7d7b35fc6e4243fd2b06R44
This is also the case for utils, etcdlib, dfi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
