pnoltes commented on code in PR #583:
URL: https://github.com/apache/celix/pull/583#discussion_r1249643203
##########
bundles/pubsub/pubsub_topology_manager/src/pubsub_topology_manager.c:
##########
@@ -1127,30 +1102,18 @@ static void
pstm_setupTopicReceivers(pubsub_topology_manager_t *manager) {
celix_arrayList_destroy(setupEntries);
}
-static void *pstm_psaHandlingThread(void *data) {
+static void pstm_psaHandlingEvent(void* data) {
pubsub_topology_manager_t *manager = data;
- celixThreadMutex_lock(&manager->psaHandling.mutex);
- bool running = manager->psaHandling.running;
- celixThreadMutex_unlock(&manager->psaHandling.mutex);
-
- while (running) {
- //first teardown -> also if rematch is needed
- pstm_teardownTopicSenders(manager);
- pstm_teardownTopicReceivers(manager);
-
- //then see if any topic sender/receiver are needed
- pstm_setupTopicSenders(manager);
- pstm_setupTopicReceivers(manager);
+ //first teardown -> also if rematch is needed
+ pstm_teardownTopicSenders(manager);
+ pstm_teardownTopicReceivers(manager);
Review Comment:
I agree and will revert the pubsub topology manager to a separate thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
