pnoltes commented on code in PR #583:
URL: https://github.com/apache/celix/pull/583#discussion_r1249643805
##########
bundles/remote_services/discovery_shm/src/discovery_shmWatcher.c:
##########
@@ -165,20 +167,15 @@ static void* discoveryShmWatcher_run(void* data) {
}
if (endpointDiscoveryServer_getUrl(discovery->server, &url[0],
MAX_LOCALNODE_LENGTH) != CELIX_SUCCESS) {
- snprintf(url, MAX_LOCALNODE_LENGTH, "http://%s:%s/%s";,
DEFAULT_SERVER_IP, DEFAULT_SERVER_PORT, DEFAULT_SERVER_PATH);
+ snprintf(url, MAX_LOCALNODE_LENGTH, "http://%s:%s/%s";,
DEFAULT_SERVER_IP, DEFAULT_SERVER_PORT,
+ DEFAULT_SERVER_PATH);
}
- while (watcher->running) {
- // register own framework
- if (discoveryShm_set(watcher->shmData, localNodePath, url) !=
CELIX_SUCCESS) {
- celix_logHelper_log(discovery->loghelper, CELIX_LOG_LEVEL_WARNING,
"Cannot set local discovery registration.");
- }
-
- discoveryShmWatcher_syncEndpoints(discovery);
- sleep(5);
+ if (discoveryShm_set(watcher->shmData, localNodePath, url) !=
CELIX_SUCCESS) {
+ celix_logHelper_log(discovery->loghelper, CELIX_LOG_LEVEL_WARNING,
"Cannot set local discovery registration.");
}
- return NULL;
+ discoveryShmWatcher_syncEndpoints(discovery);
Review Comment:
I do not think so, but will look into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
