pnoltes commented on code in PR #610:
URL: https://github.com/apache/celix/pull/610#discussion_r1288551298
##########
cmake/CelixDeps.cmake.in:
##########
@@ -6,8 +6,10 @@
$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::deployment_admin>>:find_dependency(ZLIB)
$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::dfi>>:find_dependency(libffi)>
$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::dfi>>:find_dependency(jansson)>
$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::etcdlib>>:find_dependency(jansson)>
-$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::framework>>:find_dependency(CURL)>
+$<$<BOOL:$<TARGET_NAME_IF_EXISTS:Celix::Celix::launcher>>:find_dependency(CURL)>
Review Comment:
This check target `Celix::Celix::launcher`, I think this should be
`Celix::launcher`
##########
libs/framework/CMakeLists.txt:
##########
@@ -54,7 +54,16 @@ if (FRAMEWORK)
target_include_directories(framework PRIVATE
${CMAKE_CURRENT_LIST_DIR}/include_deprecated)
target_compile_options(framework PRIVATE -DUSE_FILE32API)
target_compile_options(framework PRIVATE -Wno-deprecated-declarations)
#note part of the api is deprecated, ignore this warning on own api
+ if (NOT FRAMEWORK_CURLINIT)
+ target_compile_definitions(framework PRIVATE CELIX_NO_CURLINIT)
Review Comment:
Note that this makes use of the already existing `#ifdef CELIX_NO_CURLINIT`
in the celix_launcher.c framework source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
