PengZheng commented on code in PR #610:
URL: https://github.com/apache/celix/pull/610#discussion_r1288573916
##########
libs/framework/CMakeLists.txt:
##########
@@ -54,7 +54,16 @@ if (FRAMEWORK)
target_include_directories(framework PRIVATE
${CMAKE_CURRENT_LIST_DIR}/include_deprecated)
target_compile_options(framework PRIVATE -DUSE_FILE32API)
target_compile_options(framework PRIVATE -Wno-deprecated-declarations)
#note part of the api is deprecated, ignore this warning on own api
+ if (NOT FRAMEWORK_CURLINIT)
+ target_compile_definitions(framework PRIVATE CELIX_NO_CURLINIT)
Review Comment:
Yes, this is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
