PengZheng commented on code in PR #765: URL: https://github.com/apache/celix/pull/765#discussion_r1702035195
########## libs/utils/include/celix_err.h: ########## @@ -94,6 +94,28 @@ CELIX_UTILS_EXPORT void celix_err_printErrors(FILE* stream, const char* prefix, */ CELIX_UTILS_EXPORT int celix_err_dump(char* buf, size_t size, const char* prefix, const char* postfix); +/*! Review Comment: I just noticed that all usages of these macro are within celix_bundle_manifest.c. If we remove unnecessary duplication of manifest information (see below for more detail), then all these usages are not needed any more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
