pnoltes commented on code in PR #765:
URL: https://github.com/apache/celix/pull/765#discussion_r1835716971


##########
libs/framework/src/bundle_revision.c:
##########
@@ -24,9 +24,17 @@
 #include "bundle_revision_private.h"
 #include "framework_private.h"
 
-celix_status_t celix_bundleRevision_create(celix_framework_t* fw, const char 
*root, const char *location, manifest_pt manifest, bundle_revision_pt 
*bundle_revision) {
+struct celix_bundle_revision {
+    celix_framework_t* fw;
+    char* root;
+    char* location;
+    celix_bundle_manifest_t* manifest;

Review Comment:
   I think you are correct and I will do this in a separate PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to