[
https://issues.apache.org/jira/browse/CLK-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870529#action_12870529
]
Adrian A. commented on CLK-545:
-------------------------------
> 1. The disabled links doesn't look right. They don't look 'disabled' with the
> blue underlined text.
I'm just putting an alpha opacity of .5 over what theme/css exists. This is the
standard way of doing "disabling" of controls if I recall well.
(see the CSS above). This way it won't interfere with the custom themes. Of
course, it might look strange compared to the previous rendering, but I think
this one respects the UI guidelines. Also the users can simply override the
style now for .controlDisabled selector if this approach doesn't fit with their
desired look.
> 2. There is a security risk because the actual link is now displayed quite
> clearly in the status bar.
:). I put that as a feature, not a security risk :), because as described in
the issue, the idea for a "disabled" link is to look like a link not like a
simple piece of text wrapped in a SPAN tag. IMHO it's the duty of the business
logic or security filter to not allow the execution of that link if the user
doesn't have the credentials.
> In our apps we disable these links for the exact reasons that we don't want
> people to view the link
Well, we do the exact opposite :). We are letting the user to see what he would
get if he would have the credentials :), or if he needs to do some other tasks
before the link gets enabled.
If we don't want the user to see the "link" at all, than that wouldn't be a
"disabled link" - maybe "deactivated" ?. One might override the href, or
another approach suited for the situation.
> 3. The control is now dependent on JavaScript. So if I disable JavaScript the
> link works again.
> This wasn't a problem before. Please remember this change affects ALL links
I know no other way to show in the status bar the target (what the user might
get if it were enabled - or if it would have the rights), but still not click
on it. The only approach I've found was to put the URL in the href, but with
onClick to return false, to refuse the GET.
Do you know another approach to obtain this effect, without javascript?
> 4. If I click with the middle mouse button the link still opens, if I right
> click the link can still be opened in a new window
Now that's embarrassing :"> .
The whole point of the issue was to make the Link controls to look and behave
more like real disabled controls, i.e.:
- respect the user theme
- respect the UI guidelines about disabled controls
- have not just the look, but the "feel" of a link (by showing in the status
bar that what the user is moving over it's really a link - not just a usual
piece of text.
- the tooltip informs the user that it's a "disabled link!".
- do not allow to click on the link.
I'll further improve this issue, and any ideas are welcome :).
Thanks in advance,
Adrian.
> Better rendering of disabled link controls
> ------------------------------------------
>
> Key: CLK-545
> URL: https://issues.apache.org/jira/browse/CLK-545
> Project: Click
> Issue Type: New Feature
> Components: core
> Reporter: Adrian A.
> Assignee: Adrian A.
> Fix For: 2.3.0
>
>
> Add better rendering of disabled link controls. Right now is a simple span
> text and there's no visual hint that this might be a disabled Link (except
> for that ActionButton).
> Possible improvements:
> - 50% opacity for images/icons
> - title on mouse over
> - href browser status bar hint on mouse over (but no click possible - since
> the link is disabled)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
