[ 
https://issues.apache.org/jira/browse/CLK-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871107#action_12871107
 ] 

Bob Schellink commented on CLK-545:
-----------------------------------

No worries, at the end of the day its just software :)

The latest checkin does in fact resolve #2. However with this change we don't 
gain anything. We simply move from a <span> to an <a>. Plus we potentially 
break existing styles. For example, I can imagine existing sites using the 
following CSS to style disabled links:

span.disabled {
    text-decoration: underline;
    color: 808080;
    cursor: pointer;
}

Using a span is also advantageous in that screen readers will ignore them. When 
using <a>, I believe a screenreader will read these links. For a blind purpose 
this serves no purpose.

I also noticed that links now has a CSS dependency. While this won't matter for 
non-ajax apps it would affect the upcoming Ajax support. Reason being when a 
Ajax request is made and a link should be returned it used to be quite simple:

request -> return -> <a href="">blah</a>

With a CSS dependency the Ajax request becomes more complex:

request -> return -> <link src="control.css"></link> <a href="">blah</a> -> 
browser now has to make another request to the server to load "control.css"

Also the opacity setting doesn't work very well on text. If you look at a 
disabled button for example, the text is still very clear and easy on the eye. 
No squinting is required. That is why I was asking for pointers to the UI 
guidelines because I find it strange that they would recommend opacity for text.

> Better rendering of disabled link controls
> ------------------------------------------
>
>                 Key: CLK-545
>                 URL: https://issues.apache.org/jira/browse/CLK-545
>             Project: Click
>          Issue Type: New Feature
>          Components: core
>            Reporter: Adrian A.
>            Assignee: Adrian A.
>             Fix For: 2.3.0
>
>
> Add better rendering of disabled link controls. Right now is a simple span 
> text and there's no visual hint that this might be a disabled Link (except 
> for that ActionButton).
> Possible improvements:
> - 50% opacity for images/icons
> - title on mouse over
> - href browser status bar hint on mouse over (but no click possible - since 
> the link is disabled)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to