[
https://issues.apache.org/jira/browse/CLK-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871251#action_12871251
]
Adrian A. commented on CLK-671:
-------------------------------
>> what exact checks do you have in mind to make use of, besides the actual
>> used ones?
>1. Annotations:
> http://checkstyle.sourceforge.net/config_annotation.html
Done.
>2. Empty Block:
> http://checkstyle.sourceforge.net/config_blocks.html#EmptyBlock
It's there - line 156, but not active: Click is using many empty blocks right
now.
>3. Headers:
> http://checkstyle.sourceforge.net/config_header.html
Done.
>4. Coding:
> http://checkstyle.sourceforge.net/config_coding.html
> - (too many to enumerate them here.
IMHO also too many to add and try them now :). In fact they look so many that
it would be an issue on itself to use, configure and tune them.
> 5. Duplicate Code:
> http://checkstyle.sourceforge.net/config_duplicates.html
I would have liked this greatly but it's buggy: it shows the Apache header as
duplicate code - so it's not smart at all. If I see right it's simply using a
regular expression for this - not something like the IntelliJ inspections.
>6. More from Javadoc:
> http://checkstyle.sourceforge.net/config_javadoc.html
Done.
7. I added a few more that made sense for me. See a diff of the checkstyle file
for this.
8. There are a few others commented, because they need more test/tune before
enforcing them upon the source code.
> This might be a separate issue ....
> http://checkstyle.sourceforge.net/extending.html
Interesting concept (thought myself about it while using checkstyle), but
please move it to another issue/wiki/discussion because I consider this issue:
"upgrade to checkstyle 5.1" as closed :).
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: CLK-671
> URL: https://issues.apache.org/jira/browse/CLK-671
> Project: Click
> Issue Type: Improvement
> Reporter: George Stan
> Assignee: Adrian A.
>
> Upgrade to Checkstyle 5.1.
> It has quite a few fixes and also support for Java 5. Since Click is using
> Java 5 now this version would be more useful.
> Checkstyle 5.1 (but 5.0 too) also contains many checks not used by Click -
> /build/checkstyle-checks.xml is using just a few of them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
