The changes seems reasonable. Running checkstyle on the codebase throws the
following error though.
Any ideas?
[checkstyle]
C:\click-svn\framework\src\org\apache\click\service\TemplateService.java:0: Got
an
exception - java.lang.RuntimeException: Unable to get class information for
@throws tag
'TemplateException'.
This happens because the new check rules need the class binaries too (to
be able to perform correctness checking), so checkstyle must be run only
after the compilation of the sources.
Since our build.xml doesn't have individual "compile" tasks, one needs
to run build-all first.
I haven't changed:
<target name="checkstyle" description="run checkstyle report on Java
soruce">
to
<target name="checkstyle" depends="build-all" description="run
checkstyle report on Java soruce">
because of speed and output reasons (build-all generates lot of output
on itself)
