Github user MJJoyce commented on a diff in the pull request:

    https://github.com/apache/climate/pull/170#discussion_r26483905
  
    --- Diff: ocw/dataset_processor.py ---
    @@ -173,6 +176,11 @@ def subset(subregion, target_dataset):
         # Get subregion indices into subregion data
         dataset_slices = _get_subregion_slice_indices(subregion, 
target_dataset)
     
    +    if subregion_name:
    --- End diff --
    
    Hey Kim,
    
    You can simplify this if-else block down to simply
    
    ```
    if not subregion_name:
        subregion_name = target_dataset.name
    ```
    
    You'll need to update the line below where you pass the name as well if you 
change this of course =D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to