Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/170#issuecomment-81755128
Hey Kim,
So we currently test subsetting functionality in
https://github.com/apache/climate/blob/master/ocw/tests/test_dataset_processor.py#L174
At the moment it looks like we don't have any tests to ensure that
variables are correctly propagated through to the resulting dataset when we do
subset. However, it would probably be wise to start. This seems like a great
first step to getting that setup since we're adding new functionality here. I
would say a sanity check test to make sure that the target dataset's name is
propagated and a test that makes sure your new functionality works as expected
would be awesome.
You could check the dataset tests at
https://github.com/apache/climate/blob/master/ocw/tests/test_dataset.py#L25 for
an example of what I'm talking about.
If you have any questions let me know!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
