[
https://issues.apache.org/jira/browse/CLIMATE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381018#comment-14381018
]
ASF GitHub Bot commented on CLIMATE-598:
----------------------------------------
Github user MJJoyce commented on a diff in the pull request:
https://github.com/apache/climate/pull/183#discussion_r27176710
--- Diff: ocw/utils.py ---
@@ -335,5 +337,11 @@ def calc_climatology_monthly(dataset):
)
raise ValueError(error)
else:
- return reshape_monthly_to_annually(dataset).mean(axis=0)
+ values = reshape_monthly_to_annually(dataset).mean(axis=0)
+
+ # A year can commence from any month
+ first_month = dataset.times[0].month
--- End diff --
Hey Kim,
Just to make sure I understand what's going on here. You're trying to end
up with an array that contains all the months for a particular year right? This
is going to carry over into a following year. Is that going to be problematic
or do we just not care?
Also, being totally nitpicky but ```relativedelta(months=x)``` is better
since it's a keyword arg and we don't put spaces around those. Easy enough to
fix later though. =D
> Update time attribute of Dataset when values are reshaped
> ---------------------------------------------------------
>
> Key: CLIMATE-598
> URL: https://issues.apache.org/jira/browse/CLIMATE-598
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Reporter: Kim Whitehall
> Assignee: Kim Whitehall
>
> Currently, when the data is reshaped into monthly binned datasets to annual
> bins the time attribute of the dataset doesn't reflect the reshape.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
