[ 
https://issues.apache.org/jira/browse/CLIMATE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381052#comment-14381052
 ] 

ASF GitHub Bot commented on CLIMATE-598:
----------------------------------------

Github user kwhitehall commented on a diff in the pull request:

    https://github.com/apache/climate/pull/183#discussion_r27177986
  
    --- Diff: ocw/utils.py ---
    @@ -335,5 +337,11 @@ def calc_climatology_monthly(dataset):
             )
             raise ValueError(error)
         else:
    -        return reshape_monthly_to_annually(dataset).mean(axis=0)
    +        values = reshape_monthly_to_annually(dataset).mean(axis=0)
    +        
    +        # A year can commence from any month
    +        first_month = dataset.times[0].month
    --- End diff --
    
    Hey Mike,
    Not necessarily of a particular year, but of a year. So, for e.g. if 3 
years Jan -Dec of data the times should reflect 12 months Jan - Dec, if the 
3years were from March - Feb then the times should reflect 12 months March - 
Feb 


> Update time attribute of Dataset when values are reshaped
> ---------------------------------------------------------
>
>                 Key: CLIMATE-598
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-598
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>            Reporter: Kim Whitehall
>            Assignee: Kim Whitehall
>
> Currently, when the data is reshaped into monthly binned datasets to annual 
> bins the time attribute of the dataset doesn't reflect the reshape. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to