[
https://issues.apache.org/jira/browse/CLIMATE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651947#comment-14651947
]
ASF GitHub Bot commented on CLIMATE-654:
----------------------------------------
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/219
CLIMATE-654 - Clean up duplicate unit conversion code
- Cleanup duplicate unit conversion code in dataset_processor that was
introduced in CLIMATE-643. water_flux_unit_conversion is no longer
duplicated unnecessarily in variable_unit_conversion.
- Factor out temperature_unit_conversion code from
variable_unit_conversion. Formatting and isolation now matches that of
water_flux_unit_conversion. These are both called from the
variable_unit_conversion function so there's a convenient wrapper for
this functionality (as was the functionality prior to this refactor).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-654
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #219
----
commit 6fd064a31ea658cb082947557aaf90d3298f878a
Author: Michael Joyce <[email protected]>
Date: 2015-08-03T14:47:13Z
CLIMATE-654 - Clean up duplicate unit conversion code
- Cleanup duplicate unit conversion code in dataset_processor that was
introduced in CLIMATE-643. water_flux_unit_conversion is no longer
duplicated unnecessarily in variable_unit_conversion.
- Factor out temperature_unit_conversion code from
variable_unit_conversion. Formatting and isolation now matches that of
water_flux_unit_conversion. These are both called from the
variable_unit_conversion function so there's a convenient wrapper for
this functionality (as was the functionality prior to this refactor).
----
> Clean up duplicate unit conversion code
> ---------------------------------------
>
> Key: CLIMATE-654
> URL: https://issues.apache.org/jira/browse/CLIMATE-654
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: regridding/data processing
> Affects Versions: 0.5
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Fix For: 1.0.0
>
>
> CLIMATE-463 introduced duplicated code for unit updates in datasets. This
> ticket is for cleaning that up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
